deploy settings: generate types by default and dont deploy spec dir #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
force-pushed
the
deploy
branch
6 times, most recently
from
1bae447
to
05f616b
Compare
for a long time r10k supports generating types. It's not required to do this in a custom posthook. Also r10k has an option to ignore the spec dir from modules. To provide a good user experience we should enable it. This was introduced in r10k 3.11: https://github.com/puppetlabs/r10k/blob/main/CHANGELOG.mkd#3110
bastelfreak
added
backwards-incompatible
and removed
enhancement
jay7x
approved these changes
Jul 29, 2023
sebastianrakel
approved these changes
Jul 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for a long time r10k supports generating types. It's not required to do this in a custom posthook. Also r10k has an option to ignore the spec dir from modules. To provide a good user experience we should enable it.
This was introduced in r10k 3.11: https://github.com/puppetlabs/r10k/blob/main/CHANGELOG.mkd#3110
Pull Request (PR) description
This Pull Request (PR) fixes the following issues