Modulesync, use rspec-puppet-facts and fix tests #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed when testing operating systems other then RedHat.
This fixes a strict variables error.
`role` is used in the hiera data.
ekohl
reviewed
Nov 25, 2018
| @@ -0,0 +1,29 @@ | |||
| --- | |||
There was a problem hiding this comment.
I do wonder about excluding this (and the other nodesets) from .sync.yml
There was a problem hiding this comment.
I've opened #112 since the tests aren't running at all at the moment, (and I think there was enough going on already in this PR.)
| operatingsystemmajrelease: releasenum | ||
| } | ||
| end | ||
| on_supported_os(facterversion: '3.6').each do |os, facts| |
There was a problem hiding this comment.
There must be a better way to do this. It can be set via an env var so should we fix this in the spec helper? Can we set it via a custom fact?
There was a problem hiding this comment.
yeah, that'd make sense. We could set it to a different version depending on whether we're testing against puppet 4, 5 or 6? IIRC, I've been using 3.6 as that's the version that puppet Inc ships with puppet 4.10.
bastelfreak
approved these changes
Nov 25, 2018
dhollinger
approved these changes
Nov 25, 2018
alexjfisher
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.