Fix failing specs #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 15, 2017 17:29
These failures appear to have been caused by additional fact requirements added since the specs were first written. Additionally, the my_snmp check was failing due to a change that causes integers to be written to the config as bare numerals, not as strings.
Required for newer versions of beaker.
|
I've a task here somewhere to refactor a lot of this stuff, and this PR definitely helps move things along! Thanks for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some specs that had begun to fail due to changes introduced to the module since they were first written.
It makes some generic facts available by default to allow spec/defines/input_spec.rb to run, and updates the expected content of the my_snmp test to handle a previous change to templates/input.conf.erb which added support for non-string values.