make package work with newer puppetlabs-apt, add support for metric batch size, and update buffer limit default to current telegraf default

[htj]

Fixes #62

Tested on Ubuntu 16.04. Install package just fine, so works for me :-)

Log from applying manifest:

root@citest:/home/htj# puppet apply < /etc/puppet/manifests/telegraf.pp
Warning: /etc/puppetlabs/puppet/hiera.yaml: Use of 'hiera.yaml' version 3 is deprecated. It should be converted to version 5
(in /etc/puppetlabs/puppet/hiera.yaml)
Warning: This method is deprecated, please use the stdlib validate_legacy function, with Stdlib::Compat::String. There is further documentation for validate_legacy function in the README. at ["/etc/puppetlabs/code/environments/production/modules/telegraf/manifests/init.pp", 118]:
(at /etc/puppetlabs/code/environments/production/modules/stdlib/lib/puppet/functions/deprecation.rb:25:in deprecation') Warning: This method is deprecated, please use the stdlib validate_legacy function, with Stdlib::Compat::Absolute_Path. There is further documentation for validate_legacy function in the README. at ["/etc/puppetlabs/code/environments/production/modules/telegraf/manifests/init.pp", 123]: (at /etc/puppetlabs/code/environments/production/modules/stdlib/lib/puppet/functions/deprecation.rb:25:in deprecation')
Warning: This method is deprecated, please use the stdlib validate_legacy function, with Stdlib::Compat::Bool. There is further documentation for validate_legacy function in the README. at ["/etc/puppetlabs/code/environments/production/modules/telegraf/manifests/init.pp", 125]:
(at /etc/puppetlabs/code/environments/production/modules/stdlib/lib/puppet/functions/deprecation.rb:25:in deprecation') Warning: This method is deprecated, please use the stdlib validate_legacy function, with Stdlib::Compat::Integer. There is further documentation for validate_legacy function in the README. at ["/etc/puppetlabs/code/environments/production/modules/telegraf/manifests/init.pp", 128]: (at /etc/puppetlabs/code/environments/production/modules/stdlib/lib/puppet/functions/deprecation.rb:25:in deprecation')
Warning: This method is deprecated, please use the stdlib validate_legacy function, with Stdlib::Compat::Hash. There is further documentation for validate_legacy function in the README. at ["/etc/puppetlabs/code/environments/production/modules/telegraf/manifests/init.pp", 135]:
(at /etc/puppetlabs/code/environments/production/modules/stdlib/lib/puppet/functions/deprecation.rb:25:in deprecation') Warning: The function 'hiera_hash' is deprecated in favor of using 'lookup'. See https://docs.puppet.com/puppet/4.10/reference/deprecated_language.html (file & line not available) Warning: This method is deprecated, please use the stdlib validate_legacy function, with Pattern[]. There is further documentation for validate_legacy function in the README. at ["/etc/puppetlabs/code/environments/production/modules/apt/manifests/setting.pp", 21]: (at /etc/puppetlabs/code/environments/production/modules/stdlib/lib/puppet/functions/deprecation.rb:25:in deprecation')
Notice: Compiled catalog for citest.sei.nordu.net in environment production in 0.63 seconds
Notice: /Stage[main]/Apt/File[preferences]/ensure: created
Notice: /Stage[main]/Apt/Apt::Setting[conf-update-stamp]/File[/etc/apt/apt.conf.d/15update-stamp]/content: content changed '{md5}b9de0ac9e2c9854b1bb213e362dc4e41' to '{md5}0962d70c4ec78bbfa6f3544ae0c41974'
Notice: /Stage[main]/Telegraf::Install/Apt::Source[influxdata]/Apt::Key[Add key: 05CE15085FC09D18E99EFB22684A14CF2582E0C5 from Apt::Source influxdata]/Apt_key[Add key: 05CE15085FC09D18E99EFB22684A14CF2582E0C5 from Apt::Source influxdata]/ensure: created
Notice: /Stage[main]/Telegraf::Install/Apt::Source[influxdata]/Apt::Setting[list-influxdata]/File[/etc/apt/sources.list.d/influxdata.list]/ensure: defined content as '{md5}f12f7c5cefb1194c642d51fa6d5c09be'
Notice: /Stage[main]/Apt::Update/Exec[apt_update]: Triggered 'refresh' from 1 events
Notice: /Stage[main]/Telegraf::Install/Package[telegraf]/ensure: created
Notice: /Stage[main]/Telegraf::Config/File[/etc/telegraf/telegraf.conf]/ensure: defined content as '{md5}7e71c17c15148745d5c77308b14742ea'
Notice: /Stage[main]/Telegraf::Config/File[/etc/telegraf/telegraf.d]/owner: owner changed 'root' to 'telegraf'
Notice: /Stage[main]/Telegraf::Config/File[/etc/telegraf/telegraf.d]/group: group changed 'root' to 'telegraf'
Notice: /Stage[main]/Telegraf::Config/File[/etc/telegraf/telegraf.d]/mode: mode changed '0755' to '0750'
Notice: /Stage[main]/Telegraf::Service/Service[telegraf]: Triggered 'refresh' from 1 events
Notice: Applied catalog in 12.56 seconds

[yankcrime]

It looks like you're introducing a couple of changes here. One to introduce a new option (and to update a default?), and a second that fixes the issue with the Apt module.

Can you update your PR so that it properly describes the proposed changes?

Thanks!

[htj]

Hi, updated as requested.

Initially I just made a pull request for the first commit, but commits got added automatically when I pushed them, which really wasn't intentional.

[yankcrime]

Thanks 👍