Skip to content
This repository has been archived by the owner on Jan 1, 2023. It is now read-only.

Created polluted location reading from file #12

Merged
merged 3 commits into from
Sep 17, 2022
Merged

Created polluted location reading from file #12

merged 3 commits into from
Sep 17, 2022

Conversation

6ar8nas
Copy link
Member

@6ar8nas 6ar8nas commented Sep 16, 2022

What was done

  • Apsitvarkom.DataAccess project created, implemented PollutedLocationDTO records reading from file.
  • Implemented mapping from PollutedLocationDTO to PollutedLocation and vice-versa.
  • Unit tests written.

@6ar8nas 6ar8nas linked an issue Sep 16, 2022 that may be closed by this pull request
Create polluted location reading from a file #2
Closed
@BenasB
Copy link
Member

BenasB commented Sep 17, 2022

I haven't looked at the changed files yet, but I can see that this PR has 1 commit. Since this was a pretty big task, try to do incremental commits in the future to get a more gradual flow of updates. Nonetheless, thanks for doing this, I will review it shortly

BenasB
BenasB suggested changes Sep 17, 2022
View reviewed changes
Copy link
Member

@BenasB BenasB left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looking good, although please address the comments and push changes if needed. We may need to make the IPollutedLocationRepository methods async (database queries will definitely be async), but let's do this one step at a time.

Apsitvarkom.Api/Program.cs Outdated Show resolved Hide resolved
Apsitvarkom.DataAccess/IPollutedLocationDTORepository.cs Outdated Show resolved Hide resolved
Apsitvarkom.DataAccess/PollutedLocationsDTOFileStore.cs Outdated Show resolved Hide resolved
Apsitvarkom.DataAccess/PollutedLocationsDTOFileStore.cs Outdated Show resolved Hide resolved
Apsitvarkom.DataAccess/PollutedLocationsDTOFileStore.cs Outdated Show resolved Hide resolved
Apsitvarkom.DataAccess/PollutedLocationsDTOFileStore.cs Outdated Show resolved Hide resolved
Apsitvarkom.DataAccess/PollutedLocationsDTOFileStore.cs Outdated Show resolved Hide resolved
Apsitvarkom.DataAccess/Apsitvarkom.DataAccess.csproj Outdated Show resolved Hide resolved
Apsitvarkom.Api/Apsitvarkom.Api.csproj Show resolved Hide resolved
Apsitvarkom.UnitTests/DataAccess/PollutedLocationsFileStoreTests.cs Show resolved Hide resolved
@6ar8nas
code review changes 1/2
825c086 
mapping null to exceptions remain.
BenasB
BenasB suggested changes Sep 17, 2022
View reviewed changes
Copy link
Member

@BenasB BenasB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small things

Apsitvarkom.Models/DTO/LocationDTO.cs Outdated Show resolved Hide resolved
Apsitvarkom.Models/Mapping/PollutedLocationProfile.cs Show resolved Hide resolved
Apsitvarkom.Models/Mapping/PollutedLocationProfile.cs Show resolved Hide resolved
@github-actions
Copy link

Code Coverage

Package Line Rate Branch Rate
Apsitvarkom.DataAccess 78% 50%
Apsitvarkom.Models 100% 94%
Summary 95% (72 / 76) 89% (16 / 18)

BenasB
BenasB approved these changes Sep 17, 2022
View reviewed changes
Copy link
Member

@BenasB BenasB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, feel free to merge

@6ar8nas 6ar8nas merged commit f6dff62 into dev Sep 17, 2022
@6ar8nas 6ar8nas deleted the polluted_location_reading_from_file branch September 17, 2022 14:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BenasB BenasB BenasB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create polluted location reading from a file
2 participants
@6ar8nas @BenasB