Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reactivity): avoid infinite loop when render access a side effect computed #11135

Merged
merged 2 commits into from
Jun 14, 2024

Conversation

Doctor-wu
Copy link
Member

introduce a new dirty level MaybeDirty_ComputedSideEffect_Origin mark which computed is the original side effect one, and treat it different in triggerEffects and dirty judgement

close #11121

@Doctor-wu
Copy link
Member Author

@johnsoncodehk cc this, and we need a ecosystem test as well

@webfansplz
Copy link
Member

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented Jun 14, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools success success
nuxt success success
pinia success success
primevue success success
quasar success success
radix-vue success success
router success success
test-utils success success
vant success success
vite-plugin-vue success success
vitepress success success
vue-i18n success success
vue-macros success success
vuetify failure failure
vueuse success success
vue-simple-compiler success success

@Doctor-wu
Copy link
Member Author

Doctor-wu commented Jun 14, 2024

This PR's behaviors in test case are aligned with v3.5.0-alpha.2 as well

@yyx990803 yyx990803 merged commit 8296e19 into vuejs:main Jun 14, 2024
11 checks passed
yyx990803 added a commit that referenced this pull request Jun 28, 2024
yyx990803 pushed a commit that referenced this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maximum recursive updates exceeded in component in 3.4.27
4 participants