Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in as.POSIXlt.numeric(x) : 'origin' must be supplied (for older R versions) #1181

Open
vincentvanhees opened this issue Aug 7, 2024 · 1 comment
Open

Error in as.POSIXlt.numeric(x) : 'origin' must be supplied (for older R versions) #1181

vincentvanhees opened this issue Aug 7, 2024 · 1 comment
Assignees
@vincentvanhees
Labels
raw-data-handling (GGIRpart1)

Comments

@vincentvanhees
Copy link
Member

Handle "Error in as.POSIXlt.numeric(x) : 'origin' must be supplied" specific to older versions of R in
g.imputeTimegaps:

15315b9#commitcomment-144593248
@vincentvanhees vincentvanhees self-assigned this Aug 7, 2024
vincentvanhees added a commit that referenced this issue Aug 7, 2024
@vincentvanhees
make POSIXlt handling compatible with older R versions, fixes #1181
96e4981
vincentvanhees referenced this issue Aug 7, 2024
@vincentvanhees
specify origin to make code run in R 4.2 #1154
15315b9
@vincentvanhees
Copy link
Member Author

With the commit I made a few days ago, this seems fixed, but I am not sure this is a real solution yet:

  • It is strange the we need this for data.table::hour and not for data.table::minute and data.table::second
  • Not passing on timezone to as.POSIXct could cause issues and needs to be better tested.
  • Note that this is all very specific to older version of R.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vincentvanhees vincentvanhees

Labels
raw-data-handling (GGIRpart1)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vincentvanhees