Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language Attribute not in html tag #166

Open
jg-development opened this issue Jan 5, 2017 · 2 comments
Open

Language Attribute not in html tag #166

jg-development opened this issue Jan 5, 2017 · 2 comments

Comments

@jg-development
Copy link

Hi,

the main templates does not have the lang attribute in the html tag.
Instead of:

<!DOCTYPE html>
<html>

it should be something like that

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="<?php echo $this->getLang() ?>" lang="<?php echo $this->getLang() ?>">

Greetings Jan

@bencorlett
Copy link
Contributor

bencorlett commented Jan 5, 2017 via email

jg-development added a commit to jg-development/magento-boilerplate that referenced this issue Jan 5, 2017
@jg-development
Copy link
Author

jg-development commented Jan 5, 2017

In that case .... I created a pull request for the lang attribute only
XHTML is truely another concept

jg-development added a commit to jg-development/magento-boilerplate that referenced this issue Jan 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants