Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Webpack Defaults 2.x merge #88

Merged
merged 38 commits into from
Mar 26, 2018
Merged

refactor: Webpack Defaults 2.x merge #88

merged 38 commits into from
Mar 26, 2018

Conversation

joshwiens
Copy link
Member

@joshwiens joshwiens commented Dec 15, 2017

webpack-defaults 2.x Working branch

  • Prettier integration
  • CircleCI 2.0 Migration
  • Bug fixes from 1.x relating to the Appveyor template
  • Dependency Maint
  • Supported versions increases
  • Add minimal test configuration
  • Configure for schema enforcement
  • Add CODEOWNERS template

Subject

 refactor: Prettier integration & CircleCI 2.0 migration

Body


refactor: Update node versions for new LTS

 - Updates Node versions to current LTS

BREAKING CHANGE: Drops support for NodeJS 4.x

refactor: Use non-deprecated config type

 - Moves to non-deprecated eslint config  format

refactor: Prettier integration

 - Leverages Prettier to manage code style
 - Migrates to eslint-config-webpack 2.x ( Prettier support)
 - Updates code style per the above
 - Adds `.prettierrc` to enforce development configs

BREAKING CHANGE: Implements Prettier & modifies suported Eslint 
configuration that transfers applicable rule responsibility to Prettier

feat: Adds testing boilerplate
 - Adds contrib standard testing config

feat: Adds schema enforcement
 - Installs schema utils dependency
 - Creates `options.json` template
 - Updates build script to accommodate `options.json`

ci: Migrates to CircleCI 2.0 & custom build containers

 - Migrates to CircleCI & a full continuous delivery workflow

BREAKING CHANGE: Drops TravisCI in favor of CircleCI 2.0

BREAKING CHANGE: Drops support for Webpack 2.x & adds 4.x support

BREAKING CHANGE: Enforces existing commit message format 
in pre-commit as it's required for release automation

Migration 1.x.x => 2.x:
  • package.json: Delete all non-project specific devDependencies
  • package.json: Delete all npm scripts less "webpack-defaults": "webpack-defaults"
  • npm install webpack-defaults@next: Install defaults 2.x
  • npm run webpack-defaults: Upgrade to the latest defaults
  • .eslintrc: Transfer any custom rules to the rules object in .eslintrc.js after the prettier config array
  • .eslintrc: Remove this file
  • .travis.yml: Remove this file
  • package-lock.json: Delete this file
  • npm install: Install updated dependencies & regenerate lock file
  • Enable CircleCI 2.0 & import publishing environment variables ( requires an admin )
  • Set required validations in project settings
    • Unselect everything but the CLA check & Codecov
    • Select the following CircleCI validations after first run.

screen shot 2017-12-14 at 9 17 41 pm

Output of defaults beta.0 is visible in webpack-contrib/babel-minify-webpack-plugin#70

* refactor: Update node versions for new LTS

* refactor: Use non-deprecated config type

* refactor: Prettier & CircleCI initial conversion

 - Leverages Prettier to manage code style
 - Migrates to eslint-config-webpack 2.x ( Prettier support)
 - Updates code style per the above
 - Adds contrib standard testing config
 - Installs schema utils dependency
 - Creates `options.json` template
 - Updates Node versions to current LTS
 - Moves to non-deprecated eslint config  format
 - Migrates to CircleCI & a full continuous delivery workflow

BREAKING CHANGE: Drops support for NodeJS 4.x

BREAKING CHANGE: Implements Prettier & modifies suported Eslint configuration that transfers applicable rule responsibility to Prettier

BREAKING CHANGE: Drops TravisCI in favor of CircleCI 2.0

BREAKING CHANGE: Drops support for Webpack 2.x

BREAKING CHANGE: Enforces existing commit message format in pre-commit as it's required for release automation
@joshwiens joshwiens changed the title chore: Defaults 2.x merge refactor: Webpack Defaults 2.x merge Dec 15, 2017
@joshwiens joshwiens added this to the 2.0.0 milestone Dec 15, 2017
@michael-ciniawsky
Copy link
Member

Partial Review #86

I will review this later in depth (1-2 days) after I tried it out on a new dummy project (Setup) and on 1-2 current @next PR's e.g html-loader, style-loader, css-loader, [EWTP] (Update/Upgrade) :)

joshwiens and others added 8 commits December 15, 2017 15:01
 - Patch only coverage
 - Will not comment in PRs
* refactor: Clean up initial loader templates

* chore(package): Adds user meta packages

* refactor: Consistant pacakge template generation

* test: Adds error validation test

* refactor: FIxes urls & truncates exection command

* docs(readme): Updates usage instructions for script change

* refactor: Shorten existing package variable

* refactor: Update example options
@sapegin sapegin mentioned this pull request Dec 19, 2017
3 tasks
@joshwiens joshwiens merged commit 979bdfd into master Mar 26, 2018
@joshwiens joshwiens deleted the next branch March 28, 2018 12:46
@michael-ciniawsky michael-ciniawsky removed this from the 3.0.0 milestone Aug 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants