Geocoder refactoring using axios and AbortController objects. Fixes #400 #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrismayer
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a refactoring of the Geocoder using axios and AbortController to... abort requests when user asks for something else.
Globally, it makes the component more reactive. Before, if you typed an address while a request was running, the new address would not get searched. It should now be correctly debounced.
This PR also removes
JSONPwhich was not used anymore.It fixes #400 as axios will then be used in all requests made inside
Wegue.Eventually, unit tests are refactored too to use
axios-mock-adapteron one side and to usesinontimers on the other.Looks like
sinontimers are now working well from my side, but please give it a try to ensure it works as expected on other configurations too...