Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trusted types attributes #1268

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

Trusted types attributes #1268

wants to merge 23 commits into from

Commits on Aug 13, 2024

  1. Draft integration with Trusted Types, take 2. 

    See w3c/trusted-types#418 and whatwg#789.
Supercedes PR whatwg#809.
    @koto @lukewarlow
    koto authored and lukewarlow committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    184fbb3 View commit details
    Browse the repository at this point in the history

  2. Added integration in 'set an attribute value'.

    @koto @lukewarlow
    koto authored and lukewarlow committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    ebae0ea View commit details
    Browse the repository at this point in the history

  3. Removed stringification.

    @koto @lukewarlow
    koto authored and lukewarlow committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    3dc6eba View commit details
    Browse the repository at this point in the history

  4. Fixed formatting.

    @koto @lukewarlow
    koto authored and lukewarlow committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    f88ea29 View commit details
    Browse the repository at this point in the history

  5. Fixed copy-paste error in setAttribute() and indentation.

    @koto @lukewarlow
    koto authored and lukewarlow committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    966291f View commit details
    Browse the repository at this point in the history

  6. Fix build

    @lukewarlow
    lukewarlow committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    065ee2e View commit details
    Browse the repository at this point in the history

  7. Change code to pass sink values through to TT code.

    @lukewarlow
    lukewarlow committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    19e8f54 View commit details
    Browse the repository at this point in the history

  8. Move validate and set attribute into append an attribute

    @lukewarlow
    lukewarlow committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    964b8cd View commit details
    Browse the repository at this point in the history

  9. Remove sink values from spec

    @lukewarlow
    lukewarlow committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    8db6d26 View commit details
    Browse the repository at this point in the history

  10. Revert changes to setAttributeNode and setAttributeNodeNS method steps

    @lukewarlow
    lukewarlow committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    271a670 View commit details
    Browse the repository at this point in the history

  11. Remove throw from set an attribute and move TT check down to replace … 

    …an attribute
    @lukewarlow
    lukewarlow committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    2427ef4 View commit details
    Browse the repository at this point in the history

  12. Revert unneeded changes

    @lukewarlow
    lukewarlow committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    b5de89b View commit details
    Browse the repository at this point in the history

  13. Address comment

    @lukewarlow
    lukewarlow committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    cd0415b View commit details
    Browse the repository at this point in the history

  14. Add missing and

    @lukewarlow
    lukewarlow committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    d2adea4 View commit details
    Browse the repository at this point in the history

  15. Address some comments

    @lukewarlow
    lukewarlow committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    99ae585 View commit details
    Browse the repository at this point in the history

  16. Re-add early return

    @lukewarlow
    lukewarlow committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    f76755c View commit details
    Browse the repository at this point in the history

  17. Change dfn to use given rather than with

    @lukewarlow
    lukewarlow committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    e5be35d View commit details
    Browse the repository at this point in the history

  18. Update how the enforcement is done

    @lukewarlow
    lukewarlow committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    982ef71 View commit details
    Browse the repository at this point in the history

  19. Add tentative enforcement for toggleAttribute

    @lukewarlow
    lukewarlow committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    f584e23 View commit details
    Browse the repository at this point in the history

  20. Update enforcement for toggleAttribute to match behaviour observed in… 

    … Chrome.
    @lukewarlow
    lukewarlow committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    9b74d93 View commit details
    Browse the repository at this point in the history

  21. Revert "Update enforcement for toggleAttribute to match behaviour obs… 

    …erved in Chrome."

This reverts commit 2f00466.
    @lukewarlow
    lukewarlow committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    d836a23 View commit details
    Browse the repository at this point in the history

  22. Revert "Add tentative enforcement for toggleAttribute" 

    This reverts commit 6e40964.
    @lukewarlow
    lukewarlow committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    b0ecd77 View commit details
    Browse the repository at this point in the history

  23. Reintroduce infrastructure changes

    @lukewarlow
    lukewarlow committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    d6b3b5a View commit details
    Browse the repository at this point in the history