New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't `panic` when Env Vars are missing #48

Open

EstebanBorai opened this issue Jun 23, 2023 · 0 comments

Labels

enhancement good first issue

Collaborator

EstebanBorai commented Jun 23, 2023 •

edited

Loading

Here we could return error over paniking

https://github.com/whizzes/cargo-tag/blob/main/src/git.rs#L21-L26

EstebanBorai added enhancement good first issue labels

EstebanBorai changed the title ~~Do net panic when Env Vars are missing~~ Don't panic when Env Vars are missing

oylenshpeegul pushed a commit to oylenshpeegul/cargo-tag that referenced this issue


          Get the user.name and user.email from git config. whizzes#49

fe4e71a

Use the environment variables CARGO_TAG_NAME and CARGO_TAG_EMAIL
instead if they are set.

I think this closes whizzes#48 as well.

oylenshpeegul mentioned this issue

feat: load author from git config #51

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment