Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate to sveltekit #2

Merged
merged 7 commits into from
May 24, 2023
Merged

feat: migrate to sveltekit #2

merged 7 commits into from
May 24, 2023

Conversation

dararod
Copy link
Contributor

@dararod dararod commented May 23, 2023

No description provided.

@dararod dararod changed the title feat: sveltekit feat: migrate to sveltekit May 23, 2023
@EstebanBorai
Copy link
Collaborator

Look like the build command still uses rollup over vite?
Can you try:

https://github.com/whizzes/svelte-notifications/blob/main/package.json#L4-L14

Comment on lines -9 to -16
"scripts": {
"build": "rollup -c rollup.config.js",
"check": "tsc --noEmit",
"dev": "rollup -c rollup.config.js --watch",
"lint": "prettier --ignore-path .gitignore --check --plugin-search-dir=. . && eslint --ignore-path .gitignore .",
"format": "prettier --ignore-path .gitignore --write --plugin-search-dir=. . && eslint --fix .",
"test": "vitest"
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dararod dararod requested a review from EstebanBorai May 24, 2023 21:27
Copy link
Collaborator

@EstebanBorai EstebanBorai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@EstebanBorai EstebanBorai merged commit 4339314 into main May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants