WFCORE-6931 Remove usage of deprecated AbstractWriteAttributeHandler constructors in threads subsystem #6110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…constructors in threads subsystem
github-actions
bot
added
the
deps-ok
yersan
reviewed
Aug 21, 2024
| /** | ||
| * {@link org.jboss.as.controller.ResourceDefinition} for the root resource of the threads subsystem. | ||
| * | ||
| * @author Brian Stansberry (c) 2011 Red Hat Inc. | ||
| */ | ||
| @Deprecated(forRemoval = true) | ||
| @SuppressWarnings({"removal", "DeprecatedIsStillUsed"}) | ||
| class ThreadSubsystemResourceDefinition extends PersistentResourceDefinition { | ||
| class ThreadSubsystemResourceDefinition extends SimpleResourceDefinition { |
There was a problem hiding this comment.
I would like to understand the usage of PersistentResourceDefinition better.
Could you explain when a resource does not need to be managed as a PersistentResourceDefinition? I don't get the reason for this change yet, which in turn cascades it to the other resources
There was a problem hiding this comment.
yersan
approved these changes
Aug 26, 2024
yersan
added
the
ready-for-merge
|
Thanks @pferraro |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/WFCORE-6931