[WFCORE-6956] Wrong endpoint-name if the JBoss server name and 'jboss… #6137
Conversation
github-actions
bot
added
the
deps-ok
….node.name' are both provided to the server check for existence of Property key instead of the value on the primordialProperties
yersan
added
the
ready-for-merge
|
Thanks @jbaesner |
|
This commit really could have used a test case, which would have prevented the current error from getting through as well as demonstrating and explaining the expected behavior. I had a thorough look over it today and the change looks correct, but the logic for computing the values is not trivial, especially that it needs to work correctly (1) on a reload of the server and (2) in the case of management updates to system properties. |
|
@rachmatowicz makes sense to me, I've created this https://issues.redhat.com/browse/WFCORE-6959 to track it. My feeling is the behavior of these values is correctly managed and the original bug and resolution were pretty clear to me, but yes, I agree we could have added a test case to cover (and explain) it for the future, thanks for pointing it out. |
https://issues.redhat.com/browse/WFCORE-6956