[WFCORE-6976] acmeAccount variable is not being used #6158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, pedro-hos. I'm waiting for one of the admins to verify this patch with /ok-to-test in a comment. |
yersan
requested changes
Sep 3, 2024
There was a problem hiding this comment.
Thanks for contributing to WildFly Core @pedro-hos !
Indeed, there is also another line to be removed at L397
Would you mind removing it as well and adding the Jira link to the PR description?
Just FYI, more information about how to contribute can be found here: https://docs.wildfly.org/33/Hacking_On_WildFly.html#describe-the-pull-request-adequately
…thoritiesTestCase.java class https://issues.redhat.com/browse/WFCORE-6976
pedro-hos
force-pushed
the
WFCORE-6976
branch
from
d565660
to
100fd75
Compare
|
Hi @yersan I've made the changes and removed the other unused variable. Thank you |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
"Galleon Full integration - Linux" error is unrelated to this PR |
yersan
approved these changes
Sep 5, 2024
yersan
added
the
ready-for-merge
|
Thanks @pedro-hos ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[WFCORE-6976] acmeAccount variable is not being used on CertificateAuthoritiesTestCase.java class