Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory leak fix: do not wait for process.nextTick to clear pending callbacks #81

Merged
merged 1 commit into from
Feb 5, 2022

Conversation

smashah
Copy link
Contributor

@smashah smashah commented Feb 2, 2022

Addresses the memory leak identified here:

winstonjs/winston#1871 (comment)

@smashah smashah changed the title Memory leak fix: do not wait process.nextTick Memory leak fix: do not wait for process.nextTick to clear pending callbacks Feb 2, 2022
@DABH
Copy link
Contributor

DABH commented Feb 5, 2022

Similar to the comment on the Winston PR -- let's make sure this change doesn't break Winston tests, and if all is good, then we can merge this in.

To test this specific change, you can temporarily modify package.json for your local copy of winston and specify the version of winston-transport as ../winston-transport (e.g. the relative file path to your local copy of the repo, instead of a version number). Hope that is helpful. Thanks again for your work on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants