Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve TypeError #2328

Closed
wants to merge 4 commits into from
Closed

Resolve TypeError #2328

wants to merge 4 commits into from

Conversation

adampweb
Copy link

Issue represented here: #2327

Issue represented here: winstonjs#2327
@wbt
Copy link
Contributor

wbt commented Jul 17, 2023

Try running npm i and committing the changes to the lockfile.

@wbt
Copy link
Contributor

wbt commented Jul 22, 2023

Can anybody speak to any backward-compatibility issues that may be introduced by changing lockfile v2 to v3?

@DABH
Copy link
Contributor

DABH commented Jul 22, 2023

I mean, if CI passes…

@adampweb
Copy link
Author

Can anybody speak to any backward-compatibility issues that may be introduced by changing lockfile v2 to v3?

Based on the official documentation, backward compatibility is ensured:

3: The lockfile version used by npm v9. Backwards compatible to npm v7.

https://docs.npmjs.com/cli/v9/configuring-npm/package-lock-json#lockfileversion

@adampweb
Copy link
Author

After a bit of research and testing, I think this issue is not related to Winston but may be related with NextJS or webpack

@adampweb adampweb closed this Jul 28, 2023
@joekur
Copy link

joekur commented Aug 18, 2023

@adampweb I have run into the same issue referenced above (using winston in next.js middleware). I tested @colors/colors: 1.6.0 with npm overrides and it resolved the issue. Can we reconsider this PR? Shouldn't we support the dependency update regardless if it fixes every version of this issue?

@joekur
Copy link

joekur commented Aug 18, 2023

I'll tag @DABH on the above as well, after noticing @adampweb is an outside contributor (and may have moved on from this issue).

@ggomaeng
Copy link

Facing the same issue

@wbt
Copy link
Contributor

wbt commented Nov 8, 2023

Colors was updated in #2353 which likely fixed this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants