Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow http calls when checking Certificate Revocation List (WPB-6493) - cherrypick #2496

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

ohassine
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Description

Cherrypick of #2491

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

…-6493) (#2491)

* feat: allow http calls when checking Certificate Revocation List

* chore: detekt

* chore: unit test

* fix: use of okhttp sharedClient instead of creating a new one

* chore: unit test

* chore: unit test

* chore: add missing function for ios target

---------

Co-authored-by: Mojtaba Chenani <chenani@outlook.com>
Copy link
Contributor

github-actions bot commented Feb 14, 2024

Test Results

2 790 tests   2 661 ✔️  30s ⏱️
   483 suites     129 💤
   483 files           0

Results for commit 39349d1.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (release/candidate@b99d440). Click here to learn what that means.

Additional details and impacted files
@@                 Coverage Diff                  @@
##             release/candidate    #2496   +/-   ##
====================================================
  Coverage                     ?   58.38%           
  Complexity                   ?       21           
====================================================
  Files                        ?     1171           
  Lines                        ?    45301           
  Branches                     ?     4285           
====================================================
  Hits                         ?    26451           
  Misses                       ?    16928           
  Partials                     ?     1922           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b99d440...39349d1. Read the comment docs.

@datadog-wireapp
Copy link

Datadog Report

Branch report: allow_http_call_rc
Commit report: 28bb191
Test service: kalium-jvm

✅ 0 Failed, 2786 Passed, 123 Skipped, 11m 56.05s Wall Time

@ohassine ohassine enabled auto-merge (squash) February 14, 2024 13:44
@ohassine ohassine merged commit 889c1aa into release/candidate Feb 14, 2024
18 checks passed
@ohassine ohassine deleted the allow_http_call_rc branch February 14, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants