Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update source location strings english #2602

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Jan 22, 2024


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

New translations for base strings.

Causes (Optional)

The gh action to update source strings, run against develop only.

Solutions

Update the strings manually, later a PR should -auto- be cherry-picked to develop.

Notes

Screenshot 2024-01-22 at 10 59 48

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina self-assigned this Jan 22, 2024
@yamilmedina yamilmedina requested review from a team, typfel, alexandreferris, borichellow, Garzas and ohassine and removed request for a team January 22, 2024 09:59
@yamilmedina yamilmedina enabled auto-merge (squash) January 22, 2024 10:00
@yamilmedina yamilmedina merged commit 381f99b into release/candidate Jan 22, 2024
13 of 14 checks passed
@yamilmedina yamilmedina deleted the chore/update-source-location branch January 22, 2024 10:24
@yamilmedina yamilmedina restored the chore/update-source-location branch January 22, 2024 10:27
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@yamilmedina yamilmedina deleted the chore/update-source-location branch January 22, 2024 10:33
@AndroidBob
Copy link
Collaborator

Build 2665 succeeded.

The build produced the following APK's:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants