Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: legal hold indication on user profiles [WPB-4780] #2658

Merged
merged 7 commits into from
Feb 6, 2024

Conversation

saleniuk
Copy link
Contributor

@saleniuk saleniuk commented Feb 2, 2024

StoryWPB-4780 [Android] Legal hold indication on user profiles


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

As a user I want to see an indication on user profiles that are under legal hold so that I’m more aware of my privacy.

Solutions

Change the legal hold banner to distinguish between "legal hold active" and "legal hold request pending".
Add legal hold banner to self user profile in both cases and to other user profile when active.
Show proper dialogs when clicking on legal hold banner.

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Request legal hold for the current user or enable it for other user and open the self or other user profile to see the banner.

Attachments (Optional)

Screen_recording_20240202_164654.mp4

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Feb 2, 2024

Test Results

794 tests  +5   794 ✅ +5   12m 9s ⏱️ -41s
108 suites +1     0 💤 ±0 
108 files   +1     0 ❌ ±0 

Results for commit 6800b82. ± Comparison against base commit b629f32.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator

Build 2861 failed.

@pull-request-size pull-request-size bot added size/L and removed size/M labels Feb 2, 2024
@AndroidBob
Copy link
Collaborator

Build 2862 failed.

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (b629f32) 41.82% compared to head (6800b82) 42.50%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2658      +/-   ##
=============================================
+ Coverage      41.82%   42.50%   +0.68%     
- Complexity      1158     1171      +13     
=============================================
  Files            367      367              
  Lines          13327    13346      +19     
  Branches        1769     1773       +4     
=============================================
+ Hits            5574     5673      +99     
+ Misses          7213     7123      -90     
- Partials         540      550      +10     
Files Coverage Δ
...ld/dialog/requested/LegalHoldRequestedViewModel.kt 86.36% <ø> (-0.16%) ⬇️
...roid/ui/userprofile/other/OtherUserProfileState.kt 76.08% <100.00%> (+0.53%) ⬆️
...ndroid/ui/userprofile/self/SelfUserProfileState.kt 100.00% <100.00%> (+100.00%) ⬆️
...rc/main/kotlin/com/wire/android/ui/WireActivity.kt 0.00% <0.00%> (ø)
...id/ui/userprofile/self/SelfUserProfileViewModel.kt 47.97% <87.50%> (+47.97%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b629f32...6800b82. Read the comment docs.

Copy link
Contributor

github-actions bot commented Feb 2, 2024

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 2863 succeeded.

The build produced the following APK's:

@saleniuk saleniuk requested review from a team, typfel, alexandreferris, vitorhugods, mchenani and ohassine and removed request for a team February 5, 2024 10:02
Copy link
Contributor

@alexandreferris alexandreferris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking great! I just have a tiny comment on a hardcoded dimension

Copy link
Contributor

github-actions bot commented Feb 5, 2024

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 2870 succeeded.

The build produced the following APK's:

@saleniuk saleniuk added this pull request to the merge queue Feb 6, 2024
Merged via the queue into develop with commit fe78d52 Feb 6, 2024
14 checks passed
@saleniuk saleniuk deleted the feat/legal-hold-indication-profile branch February 6, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants