Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove jacoco and migrate to kover (ACOL-139) #2670

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Feb 7, 2024

TopicACOL-139 Min. code coverage thresholds


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Follow up of #2662 to improve test coverage

Solutions

  • Removes jacoco config.
  • Use kover for better coverage support and filtering of classes and annotations.

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina self-assigned this Feb 7, 2024
@yamilmedina yamilmedina requested review from alexandreferris, mchenani and saleniuk and removed request for a team February 7, 2024 14:10
@@ -540,7 +540,6 @@ pipeline {
}
}

sh './gradlew jacocoReport'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dead code, not used, since coverage runs on gh actions.

@yamilmedina yamilmedina merged commit fd1b0e2 into release/candidate Feb 7, 2024
13 of 14 checks passed
@yamilmedina yamilmedina deleted the chore/test-migrate-to-kover branch February 7, 2024 14:43
Copy link
Contributor

github-actions bot commented Feb 7, 2024

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 2947 succeeded.

The build produced the following APK's:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants