Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable MLS for beta build flavour (ACOL-146) #2675

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Feb 8, 2024

TopicACOL-146 Start testing MLS builds on Release instead of debug build type


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Description

Enabling MLS for all flavours and keep it off for prod.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@ohassine ohassine requested review from a team, typfel, borichellow, vitorhugods, Garzas and saleniuk and removed request for a team February 8, 2024 15:41
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ecb7ff1) 42.86% compared to head (3130baf) 42.86%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2675      +/-   ##
===========================================
- Coverage    42.86%   42.86%   -0.01%     
===========================================
  Files          405      405              
  Lines        13463    13462       -1     
  Branches      2376     2375       -1     
===========================================
- Hits          5771     5770       -1     
  Misses        7013     7013              
  Partials       679      679              

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecb7ff1...3130baf. Read the comment docs.

Copy link
Contributor

github-actions bot commented Feb 8, 2024

Test Results

816 tests  ±0   816 ✅ ±0   13m 4s ⏱️ +48s
113 suites ±0     0 💤 ±0 
113 files   ±0     0 ❌ ±0 

Results for commit 3130baf. ± Comparison against base commit ecb7ff1.

Copy link
Contributor

github-actions bot commented Feb 8, 2024

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 2995 succeeded.

The build produced the following APK's:

@MohamadJaara MohamadJaara added this pull request to the merge queue Feb 8, 2024
Merged via the queue into develop with commit 6e15627 Feb 8, 2024
23 checks passed
@MohamadJaara MohamadJaara deleted the enable_mls_beta branch February 8, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants