Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow http calls when checking Certificate Revocation List (WPB-6493) #2700

Merged
merged 3 commits into from
Feb 14, 2024

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Feb 13, 2024

BugWPB-6493 [Androdi] Handle Http call error


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Description

Please check this PR for details wireapp/kalium#2491

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@ohassine ohassine requested review from a team, typfel, yamilmedina, borichellow, MohamadJaara and mchenani and removed request for a team February 13, 2024 15:40
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (15bc6f3) 42.77% compared to head (cf663b9) 42.94%.
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2700      +/-   ##
===========================================
+ Coverage    42.77%   42.94%   +0.17%     
===========================================
  Files          408      408              
  Lines        13516    13516              
  Branches      2389     2389              
===========================================
+ Hits          5781     5805      +24     
+ Misses        7059     7028      -31     
- Partials       676      683       +7     

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15bc6f3...cf663b9. Read the comment docs.

Copy link
Contributor

github-actions bot commented Feb 13, 2024

Test Results

816 tests  ±0   816 ✅ ±0   13m 2s ⏱️ + 3m 45s
114 suites ±0     0 💤 ±0 
114 files   ±0     0 ❌ ±0 

Results for commit cf663b9. ± Comparison against base commit 15bc6f3.

♻️ This comment has been updated with latest results.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 3105 succeeded.

The build produced the following APK's:

@mchenani mchenani added this pull request to the merge queue Feb 14, 2024
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 3130 succeeded.

The build produced the following APK's:

Merged via the queue into develop with commit 8be3239 Feb 14, 2024
14 checks passed
@mchenani mchenani deleted the allow_http_call_when_checking_crl branch February 14, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants