Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement use case to get default conversation creation protocol (WPB-5475) #2725

Conversation

AndroidBob
Copy link
Collaborator

@AndroidBob AndroidBob commented Feb 21, 2024

BugWPB-5475 [Android] Default Protocol not followed when changes are applied in Team Management

Cherry pick from the original PR:


⚠️ Conflicts during cherry-pick:
kalium


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Default Protocol was not correctly displayed when set by team owner.

Causes (Optional)

Not implemented.

Solutions

Display default protocol when set by team owner.

Needs releases with:

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

  • Have a team on diya or elna environment, with TeamOwner A and Member B
  • Enable MLS for the team and select user A and B to have MLS permissions
  • Login with user B to android
  • Login to Team Management with user A
  • Select “Default Protocol: MLS” in Team Management MLS configurations
  • Create a group on android with user B
  • During group creation flow, the default protocol should automatically show “MLS” (and if I tap the protocol option, I have to option to select “Proteus”)

Attachments (Optional)

@AndroidBob AndroidBob added the cherry-pick PR is cherry-picking changes from another banch label Feb 21, 2024
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (80aa6a3) 43.00% compared to head (fb1b9e0) 43.11%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2725      +/-   ##
===========================================
+ Coverage    43.00%   43.11%   +0.10%     
===========================================
  Files          408      408              
  Lines        13532    13540       +8     
  Branches      2392     2393       +1     
===========================================
+ Hits          5820     5838      +18     
+ Misses        7028     7017      -11     
- Partials       684      685       +1     
Files Coverage Δ
...i/home/newconversation/NewConversationViewModel.kt 57.14% <100.00%> (+3.06%) ⬆️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80aa6a3...fb1b9e0. Read the comment docs.

@alexandreferris alexandreferris requested review from a team, typfel, yamilmedina, borichellow, mchenani and saleniuk and removed request for a team February 21, 2024 15:14
Copy link
Contributor

Test Results

821 tests  +1   821 ✅ +1   14m 2s ⏱️ + 4m 54s
114 suites ±0     0 💤 ±0 
114 files   ±0     0 ❌ ±0 

Results for commit fb1b9e0. ± Comparison against base commit 80aa6a3.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator Author

Build 3245 succeeded.

The build produced the following APK's:

@alexandreferris alexandreferris added this pull request to the merge queue Feb 21, 2024
Merged via the queue into develop with commit ff529ed Feb 21, 2024
17 checks passed
@alexandreferris alexandreferris deleted the fix/get_default_protocol_when_creating_group-cherry-pick branch February 21, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants