Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding fdroid flavor to build without GMS and Firebase (WPB-2799) #2727

Merged
merged 49 commits into from
Feb 22, 2024

Conversation

e-lisa
Copy link
Contributor

@e-lisa e-lisa commented Feb 22, 2024

StoryWPB-2799 Submit wire-android-reloaded to F-Droid


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Briefly describe the issue you have solved or implemented with this pull request. If the PR contains multiple issues, use a bullet list.

Causes (Optional)

Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.

Solutions

Briefly describe the solutions you have implemented for the issues explained above.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

e-lisa and others added 30 commits January 24, 2024 10:46
Copy link
Contributor

github-actions bot commented Feb 22, 2024

Test Results

821 tests  ±0   821 ✅ ±0   8m 52s ⏱️ - 1m 0s
114 suites ±0     0 💤 ±0 
114 files   ±0     0 ❌ ±0 

Results for commit d0cfdb6. ± Comparison against base commit ff529ed.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ff529ed) 42.95% compared to head (d0cfdb6) 42.96%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2727   +/-   ##
========================================
  Coverage    42.95%   42.96%           
========================================
  Files          408      408           
  Lines        13539    13522   -17     
  Branches      2392     2389    -3     
========================================
- Hits          5816     5810    -6     
+ Misses        7046     7036   -10     
+ Partials       677      676    -1     
Files Coverage Δ
...e/messagecomposer/location/LocationPickerHelper.kt 72.72% <100.00%> (+26.57%) ⬆️
...essagecomposer/location/LocationPickerViewModel.kt 86.36% <100.00%> (ø)
...mposer/state/MessageCompositionInputStateHolder.kt 67.85% <ø> (ø)
...oid/ui/home/settings/account/MyAccountViewModel.kt 83.72% <ø> (ø)
.../account/email/updateEmail/ChangeEmailViewModel.kt 62.74% <ø> (ø)
...e/settings/account/handle/ChangeHandleViewModel.kt 84.84% <ø> (ø)
.../kotlin/com/wire/android/util/extension/Context.kt 0.00% <ø> (-28.58%) ⬇️
...om/wire/android/initializer/FirebaseInitializer.kt 0.00% <ø> (ø)
...e/android/services/WireFirebaseMessagingService.kt 0.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff529ed...d0cfdb6. Read the comment docs.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 3257 succeeded.

The build produced the following APK's:

@tmspzz tmspzz added this pull request to the merge queue Feb 22, 2024
Merged via the queue into develop with commit 0e0430d Feb 22, 2024
14 checks passed
@tmspzz tmspzz deleted the fdroid-flavor branch February 22, 2024 13:27
MohamadJaara pushed a commit that referenced this pull request Mar 25, 2024
…9) (#2727)

Co-authored-by: Yamil Medina <yamilmedina@users.noreply.github.com>
Co-authored-by: Mohamad Jaara <mohamad.jaara@wire.com>

(cherry picked from commit 0e0430d)
MohamadJaara added a commit that referenced this pull request Mar 25, 2024
…9) (#2727) cherry pick (#2813)

Co-authored-by: Lisa Marie Maginnis <lisa.marie@hypatiahelps.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants