Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add structured logs to location and fix permission handling (WPB-6358) #2736

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

AndroidBob
Copy link
Collaborator

@AndroidBob AndroidBob commented Feb 23, 2024

TaskWPB-6358 [Android] Location feature logs observability

Cherry pick from the original PR:


⚠️ Conflicts during cherry-pick:
app/src/main/kotlin/com/wire/android/ui/home/messagecomposer/location/LocationPickerHelper.kt


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

  • Add logs while getting location, so we can monitor for example; usages by gms, non-gms, location not enabled, etc.

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. .

@AndroidBob AndroidBob added the cherry-pick PR is cherry-picking changes from another banch label Feb 23, 2024
Copy link
Contributor

github-actions bot commented Feb 23, 2024

Test Results

821 tests  ±0   821 ✅ ±0   12m 43s ⏱️ + 1m 46s
114 suites ±0     0 💤 ±0 
114 files   ±0     0 ❌ ±0 

Results for commit e5bd130. ± Comparison against base commit e31b062.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator Author

Build 3308 failed.

@@ -69,7 +69,7 @@ android {
// For all other flavors use the "nonfree" sourceSets
} else {
getByName("main") {
java.srcDirs("src/nonfree/kotlin")
java.srcDirs("src/main/kotlin", "src/nonfree/kotlin")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix, otherwise we don't have autocompletion at all for classes coming from this nonfree

@yamilmedina yamilmedina requested review from a team, typfel, borichellow, vitorhugods, mchenani and Garzas and removed request for a team February 23, 2024 14:16
@yamilmedina yamilmedina added this pull request to the merge queue Feb 23, 2024
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 43.12%. Comparing base (e31b062) to head (e5bd130).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2736   +/-   ##
========================================
  Coverage    43.12%   43.12%           
========================================
  Files          408      408           
  Lines        13522    13544   +22     
  Branches      2390     2392    +2     
========================================
+ Hits          5831     5841   +10     
- Misses        7007     7018   +11     
- Partials       684      685    +1     
Files Coverage Δ
...e/messagecomposer/location/LocationPickerHelper.kt 85.71% <100.00%> (+12.98%) ⬆️
app/src/main/kotlin/com/wire/android/AppLogger.kt 58.82% <50.00%> (-21.18%) ⬇️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e31b062...e5bd130. Read the comment docs.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator Author

Build 3309 succeeded.

The build produced the following APK's:

Merged via the queue into develop with commit e9cd1a9 Feb 23, 2024
14 checks passed
@yamilmedina yamilmedina deleted the chore/location-logs-cherry-pick branch February 23, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants