Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix tag logging for internal and staging flavors #2739

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

saleniuk
Copy link
Contributor


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

This PR: #2733 provided a fix for beta flavor, but DataDogLogger is still outdated for some other flavors.
This commit fixed it for dev flavor only for RC: e11de8a

Solutions

Fix it also for other flavors.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

Test Results

803 tests   803 ✅  8m 51s ⏱️
108 suites    0 💤
108 files      0 ❌

Results for commit 36c68f4.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@mchenani mchenani merged commit 295d618 into release/candidate Feb 26, 2024
14 of 15 checks passed
@mchenani mchenani deleted the chore/fix-tag-logging-for-other-flavors branch February 26, 2024 14:12
@AndroidBob
Copy link
Collaborator

Build 3339 succeeded.

The build produced the following APK's:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants