Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove third party library for certificate decoding (WPB-6765) #2746

Merged

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Feb 28, 2024

BugWPB-6765 [Android] Remove 3rd part libs deps for Cert Decoding


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Certificate decoding was done by a third part library, now it's provided from Core Crypro

Solutions

Remove current implementation for decoding E2EI certificate and get info from CC instead

Needs this PR on Kalium
wireapp/kalium#2557

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@ohassine ohassine requested review from a team, typfel, yamilmedina, mchenani, Garzas and saleniuk and removed request for a team February 28, 2024 11:07
Copy link
Contributor

Test Results

803 tests   803 ✅  10m 15s ⏱️
108 suites    0 💤
108 files      0 ❌

Results for commit 6a324f1.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 3357 succeeded.

The build produced the following APK's:

@ohassine ohassine merged commit 617beeb into release/candidate Feb 28, 2024
25 checks passed
@ohassine ohassine deleted the remove_third_party_library_for_cert_decoding branch February 28, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants