Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade kotlin to 1.9.23 #2767

Merged
merged 8 commits into from
Apr 2, 2024
Merged

Conversation

vitorhugods
Copy link
Member

@vitorhugods vitorhugods commented Mar 5, 2024


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Other than Kotlin being a bit behind (1.9.0, considering 1.9.22 is available), some other libraries are lagging behind.
Kotlin 2.0 is around the corner and we should try to keep up to catch breaking changes and deal with them earlier.

Solutions

Update as much as we can and reasonably can on develop before getting too close to a 4.7.0 release. So when we finally make the jump to 2.0 (whenever that might be), it won't be as much of a hassle.

Important

No Compose/Material updates to avoid breaking UI changes.
The only change was the compose compiler, to keep it compatible with Kotlin 1.9.22. The compiler itself does not change UI looks.

Testing

Ran tests and the Android app locally. Everything alright.

Dependencies

This PR depends on:


PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@vitorhugods vitorhugods requested review from a team, alexandreferris, MohamadJaara, Garzas, ohassine and saleniuk and removed request for a team March 5, 2024 10:59
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 43.20%. Comparing base (e3ed13b) to head (9ec078c).

❗ Current head 9ec078c differs from pull request most recent head 46de2d3. Consider uploading reports for the commit 46de2d3 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2767      +/-   ##
===========================================
- Coverage    43.62%   43.20%   -0.43%     
===========================================
  Files          422      409      -13     
  Lines        14087    13555     -532     
  Branches      2543     2359     -184     
===========================================
- Hits          6146     5856     -290     
+ Misses        7225     7015     -210     
+ Partials       716      684      -32     
Files Coverage Δ
...rc/main/kotlin/com/wire/android/WireApplication.kt 56.52% <0.00%> (+5.83%) ⬆️

... and 94 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3ed13b...46de2d3. Read the comment docs.

Copy link
Contributor

github-actions bot commented Mar 5, 2024

Test Results

878 tests  ±0   878 ✅ ±0   10m 33s ⏱️ + 2m 7s
120 suites ±0     0 💤 ±0 
120 files   ±0     0 ❌ ±0 

Results for commit c0eb0e9. ± Comparison against base commit e3ed13b.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Mar 5, 2024

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 3481 failed.

@AndroidBob
Copy link
Collaborator

Build 3492 succeeded.

The build produced the following APK's:

@vitorhugods vitorhugods changed the title chore: upgrade kotlin to 1.9.22 chore: upgrade kotlin to 1.9.23 Apr 2, 2024
@vitorhugods vitorhugods force-pushed the chore/upgrade-to-kotlin-1.9.22 branch from 31432f8 to 46b6560 Compare April 2, 2024 10:45
@AndroidBob
Copy link
Collaborator

Build 3904 failed.

@AndroidBob
Copy link
Collaborator

Build 3905 failed.

@pull-request-size pull-request-size bot added size/S and removed size/XS labels Apr 2, 2024
@AndroidBob
Copy link
Collaborator

Build 3906 failed.

@pull-request-size pull-request-size bot added size/XL and removed size/S labels Apr 2, 2024
Copy link

Ups 🫰🟨

This PR is too big. Please try to break it up into smaller PRs.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 43.75%. Comparing base (e3ed13b) to head (c0eb0e9).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2767      +/-   ##
===========================================
+ Coverage    43.62%   43.75%   +0.12%     
===========================================
  Files          422      422              
  Lines        14087    14057      -30     
  Branches      2543     2501      -42     
===========================================
+ Hits          6146     6150       +4     
+ Misses        7225     7189      -36     
- Partials       716      718       +2     
Files Coverage Δ
...rc/main/kotlin/com/wire/android/WireApplication.kt 55.71% <0.00%> (+5.02%) ⬆️

... and 14 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3ed13b...c0eb0e9. Read the comment docs.

Copy link
Contributor

github-actions bot commented Apr 2, 2024

APKs built during tests are available here. Scroll down to Artifacts!

@vitorhugods vitorhugods merged commit f71d13e into develop Apr 2, 2024
8 checks passed
@vitorhugods vitorhugods deleted the chore/upgrade-to-kotlin-1.9.22 branch April 2, 2024 14:50
@AndroidBob
Copy link
Collaborator

Build 3908 succeeded.

The build produced the following APK's:

Copy link
Contributor

github-actions bot commented Apr 2, 2024

APKs built during tests are available here. Scroll down to Artifacts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants