Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move remove message to conv messages view model #2823

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Mar 26, 2024


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

  • moved remove message functionality to conversation messages view model

Copy link
Contributor

github-actions bot commented Mar 26, 2024

Test Results

878 tests  ±0   878 ✅ ±0   14m 41s ⏱️ + 3m 21s
118 suites ±0     0 💤 ±0 
118 files   ±0     0 ❌ ±0 

Results for commit 4af6060. ± Comparison against base commit 9e45252.

This pull request removes 6 and adds 6 tests. Note that renamed tests count towards both.
com.wire.android.ui.home.conversations.MessageComposerViewModelTest ‑ given a failure, when deleting messages, then the delete dialog state is closed()
com.wire.android.ui.home.conversations.MessageComposerViewModelTest ‑ given a failure, when deleting messages, then the error state is updated()
com.wire.android.ui.home.conversations.MessageComposerViewModelTest ‑ validate deleteMessageDialogsState states when deleteMessageDialog is visible for my message()
com.wire.android.ui.home.conversations.MessageComposerViewModelTest ‑ validate deleteMessageDialogsState states when deleteMessageDialog is visible for others message()
com.wire.android.ui.home.conversations.MessageComposerViewModelTest ‑ validate deleteMessageDialogsState states when deleteMessageForYourselfDialog is visible()
com.wire.android.ui.home.conversations.MessageComposerViewModelTest ‑ validate deleteMessageDialogsState states when dialogs are dismissed()
com.wire.android.ui.home.conversations.messages.ConversationMessagesViewModelTest ‑ given a failure, when deleting messages, then the delete dialog state is closed()
com.wire.android.ui.home.conversations.messages.ConversationMessagesViewModelTest ‑ given a failure, when deleting messages, then the error state is updated()
com.wire.android.ui.home.conversations.messages.ConversationMessagesViewModelTest ‑ validate deleteMessageDialogsState states when deleteMessageDialog is visible for my message()
com.wire.android.ui.home.conversations.messages.ConversationMessagesViewModelTest ‑ validate deleteMessageDialogsState states when deleteMessageDialog is visible for others message()
com.wire.android.ui.home.conversations.messages.ConversationMessagesViewModelTest ‑ validate deleteMessageDialogsState states when deleteMessageForYourselfDialog is visible()
com.wire.android.ui.home.conversations.messages.ConversationMessagesViewModelTest ‑ validate deleteMessageDialogsState states when dialogs are dismissed()

♻️ This comment has been updated with latest results.

@Garzas Garzas enabled auto-merge March 26, 2024 12:42
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 93.10345% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 43.64%. Comparing base (9e45252) to head (4af6060).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2823   +/-   ##
========================================
  Coverage    43.64%   43.64%           
========================================
  Files          419      419           
  Lines        14025    14025           
  Branches      2536     2536           
========================================
  Hits          6121     6121           
  Misses        7186     7186           
  Partials       718      718           
Files Coverage Δ
.../ui/home/conversations/MessageComposerViewModel.kt 82.05% <ø> (-1.16%) ⬇️
...rsations/messages/ConversationMessagesViewModel.kt 64.44% <93.10%> (+5.23%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e45252...4af6060. Read the comment docs.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 3767 succeeded.

The build produced the following APK's:

@Garzas Garzas added this pull request to the merge queue Mar 26, 2024
Merged via the queue into develop with commit 7e37bcb Mar 26, 2024
14 checks passed
@Garzas Garzas deleted the chore/move-delete-message-to-messages-view-model branch March 26, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants