Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove conversation id from send message viewmodel to make it reausable #2834

Merged
merged 3 commits into from
Mar 28, 2024

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Mar 28, 2024


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

  • removed conversation Id and savedStateHandle from SendMessageViewModel to make it reusable in ImportMediaScreen where user can select conversation to which he can send assets
  • added conversationId do UIMessages

Copy link
Contributor

github-actions bot commented Mar 28, 2024

Test Results

878 tests  ±0   878 ✅ ±0   8m 51s ⏱️ - 2m 24s
120 suites ±0     0 💤 ±0 
120 files   ±0     0 ❌ ±0 

Results for commit 0ca093c. ± Comparison against base commit 7d5208b.

♻️ This comment has been updated with latest results.

@Garzas Garzas enabled auto-merge March 28, 2024 10:32
@@ -0,0 +1,60 @@
/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 82.81250% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 43.78%. Comparing base (7d5208b) to head (0ca093c).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2834      +/-   ##
===========================================
+ Coverage    43.71%   43.78%   +0.06%     
===========================================
  Files          421      422       +1     
  Lines        14019    14034      +15     
  Branches      2537     2537              
===========================================
+ Hits          6129     6145      +16     
+ Misses        7171     7169       -2     
- Partials       719      720       +1     
Files Coverage Δ
.../ui/home/conversations/MessageComposerViewState.kt 80.76% <100.00%> (+1.60%) ⬆️
.../wire/android/ui/home/conversations/MessageItem.kt 0.00% <ø> (ø)
...android/ui/home/conversations/SystemMessageItem.kt 0.00% <ø> (ø)
...e/android/ui/home/conversations/model/UIMessage.kt 52.45% <100.00%> (+0.29%) ⬆️
...in/kotlin/com/wire/android/mapper/MessageMapper.kt 61.00% <50.00%> (-0.23%) ⬇️
.../messagecomposer/state/MessageCompositionHolder.kt 38.84% <0.00%> (-6.09%) ⬇️
...i/home/messagecomposer/model/MessageComposition.kt 23.37% <0.00%> (-0.63%) ⬇️
...oid/ui/home/messagecomposer/model/MessageBundle.kt 87.50% <87.50%> (ø)
.../conversations/sendmessage/SendMessageViewModel.kt 83.11% <84.61%> (-0.65%) ⬇️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d5208b...0ca093c. Read the comment docs.

@Garzas Garzas added this pull request to the merge queue Mar 28, 2024
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

Merged via the queue into develop with commit bee00f0 Mar 28, 2024
13 of 14 checks passed
@Garzas Garzas deleted the chore/send-message-independent-from-conversation-id branch March 28, 2024 11:04
@AndroidBob
Copy link
Collaborator

Build 3821 succeeded.

The build produced the following APK's:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants