feat: extracting commons ui elements - sketch pt3 #2859
Conversation
yamilmedina
changed the title
yamilmedina
requested review from
a team,
typfel,
vitorhugods,
mchenani,
Garzas,
saleniuk and
alexandreferris
and removed request for
a team
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 3987 succeeded. The build produced the following APK's: |
| @@ -79,15 +78,15 @@ fun WirePrimaryIconButton( | |||
| @Preview | |||
| @Composable | |||
| fun PreviewWirePrimaryIconButton() { | |||
| WirePrimaryIconButton({}, false, R.drawable.ic_add, 0) | |||
| WirePrimaryIconButton({}, false, com.google.android.material.R.drawable.m3_password_eye, 0) | |||
There was a problem hiding this comment.
I suppose the new icon is to be as "default" until we have the project drawables into ui-common module as well, right?
There was a problem hiding this comment.
Yup, forgot to mention, this drawable was used for previews only in these components, that's why I replaced it on the components.
The real resource we passed from specific modules, in our case App or new feature modules :D
| @@ -1,4 +1,4 @@ | |||
| /* | |||
| package com.wire.android.ui.common.snackbar/* | |||
There was a problem hiding this comment.
| package com.wire.android.ui.common.snackbar/* | |
| package com.wire.android.ui.common.snackbar | |
| /* |
| @@ -18,6 +18,7 @@ | |||
|
|
|||
| package com.wire.android.ui.theme | |||
|
|
|||
| //import com.wire.android.navigation.rememberNavigator | |||
There was a problem hiding this comment.
I commented it for now, since it was only used for Previews as you can see down below in line ~50.
We need at some point to bring the navigation as well to a separate module, but for now I wanted to keep it simple and less invasive 😅 hope is not a problem for the team. (actually removing it, does not break previews).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat/sketching-proto-pt2 #2859 +/- ##
============================================================
+ Coverage 43.75% 43.83% +0.08%
============================================================
Files 424 422 -2
Lines 14068 14056 -12
Branches 2501 2499 -2
============================================================
+ Hits 6156 6162 +6
+ Misses 7195 7176 -19
- Partials 717 718 +1 see 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 3993 succeeded. The build produced the following APK's: |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
Introducing modules, and reducing duplication for components needed for sketch
Causes (Optional)
Not done.
Solutions
Create UI components module, preserving package structure, and move only relevant things first.
That will be reused for sure, example, buttons, scaffold, and its dependencies when needed.
The idea of preserving package structure, is to not mess up with the imports of the app, and reduce at the minimum, the changes, preserving history, and other benefits.
For later (if needed) we have a base to continue moving components as needed.
How to Test
The app should compile and start without problems :)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.