Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: reply markdown [WPB-3558] #2904

Merged
merged 4 commits into from
Apr 17, 2024
Merged

feat: reply markdown [WPB-3558] #2904

merged 4 commits into from
Apr 17, 2024

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Apr 17, 2024 •
edited by github-actions bot
Loading

BugWPB-3558 Android - For reply messages markdowns doesn't work

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Implemented markdown for handling reply

Wire 2024-04-17 at 11_18 AM

@Garzas Garzas self-assigned this Apr 17, 2024
@Garzas Garzas requested a review from ohassine April 17, 2024 09:20
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 17, 2024 •
edited
Loading

Test Results

890 tests  ±0   890 ✅ ±0   14m 44s ⏱️ - 3m 7s
122 suites ±0     0 💤 ±0 
122 files   ±0     0 ❌ ±0 

Results for commit 49ccb64. ± Comparison against base commit 25ec09e.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@Garzas Garzas added this pull request to the merge queue Apr 17, 2024
Merged via the queue into develop with commit 7e10577 Apr 17, 2024
11 of 12 checks passed
@Garzas Garzas deleted the feat/reply-markdown branch April 17, 2024 11:03
@AndroidBob
Copy link
Collaborator

Build 4265 succeeded.

The build produced the following APK's:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yamilmedina yamilmedina yamilmedina approved these changes

@MohamadJaara MohamadJaara MohamadJaara approved these changes

@vitorhugods vitorhugods Awaiting requested review from vitorhugods

@saleniuk saleniuk Awaiting requested review from saleniuk

@ohassine ohassine Awaiting requested review from ohassine

Assignees

@Garzas Garzas

Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Garzas @AndroidBob @yamilmedina @MohamadJaara