Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Setup workflows to build all variants in the app (WPB-8644) #3014

Merged
merged 47 commits into from
May 28, 2024
Merged

ci: Setup workflows to build all variants in the app (WPB-8644) #3014

merged 47 commits into from
May 28, 2024

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented May 17, 2024 •
edited by github-actions bot
Loading

TaskWPB-8644 [Android] Setup pipeline step to build all variants in the app

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Description

Created 4 workflows to build apks from develop, prod, internal and main based on some events.

  • On each push/pull request into/against develop we build: DevDebug and StagingRelease

  • On each push/pull request into/against prod we build: ProdCompatRelease

  • On each tag created starting with "v**" a new ProdCompatRelease is created

  • On each push/pull request into/against main we build: BetaRelease

  • On each push/pull request into/against release/candidate we build: InternalCompat and StagingCompat

The steps will be like this:

Screenshot 2024-05-27 at 11 10 48

Next PR will be for uploading the app to beta and prod tracks.

Needs releases with:

  • GitHub link to other pull request
  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.
References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@AndroidBob
Copy link
Collaborator

Build 4800 failed.

@ohassine
Merge remote-tracking branch 'origin/develop' into setup-workflow-bui…
cdfdcd8 
…ld-app

# Conflicts:
#	.github/workflows/build-app.yml
#	.github/workflows/gradle-run-unit-tests.yml
@ohassine ohassine changed the title CI: Setup workflows to build all variants in the app (WPB-8644) ci: Setup workflows to build all variants in the app (WPB-8644) May 21, 2024
@AndroidBob
Copy link
Collaborator

Build 4825 failed.

@AndroidBob
Copy link
Collaborator

Build 4863 failed.

@AndroidBob
Copy link
Collaborator

Build 4869 failed.

@yamilmedina yamilmedina changed the title ci: Setup workflows to build all variants in the app (WPB-8644) chore(ci): Setup workflows to build all variants in the app (WPB-8644) May 22, 2024
@AndroidBob
Copy link
Collaborator

Build 4924 failed.

@ohassine ohassine added the WIP Work In Progress label May 23, 2024
@AndroidBob
Copy link
Collaborator

Build 4934 failed.

@AndroidBob
Copy link
Collaborator

Build 4939 failed.

@github-actions GitHub Actions
Copy link
Contributor

@ohassine looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
323fad3c7ba910ccafaa3a279007d5ace1607e8c dcd806b84178f1873df629a427a573a22bf027c9

Is this intentional?

@pull-request-size pull-request-size bot added size/M and removed size/L labels May 27, 2024
@AndroidBob
Copy link
Collaborator

Build 5020 failed.

@AndroidBob
Copy link
Collaborator

Build 5022 succeeded.

The build produced the following APK's:

@vitorhugods
Copy link
Member

After this is merged, we got to update the branch rules so we require ui-tests / ui-tests (29) and unit-tests / coverage for PRs, instead of ui-tests (29) and unit-tests that we currently do

@ohassine ohassine enabled auto-merge May 28, 2024 09:56
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@AndroidBob
Copy link
Collaborator

Build 5036 succeeded.

The build produced the following APK's:

@ohassine ohassine disabled auto-merge May 28, 2024 11:37
@ohassine ohassine merged commit 482c179 into develop May 28, 2024
11 checks passed
@ohassine ohassine deleted the setup-workflow-build-app branch May 28, 2024 11:38
@echoes-hq echoes-hq bot added the echoes: throughput/ci-maintenance Changes we need to do to keep CI healthy and fast label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yamilmedina yamilmedina yamilmedina approved these changes

@vitorhugods vitorhugods vitorhugods approved these changes

@borichellow borichellow Awaiting requested review from borichellow

@alexandreferris alexandreferris Awaiting requested review from alexandreferris alexandreferris was automatically assigned from wireapp/android

@saleniuk saleniuk Awaiting requested review from saleniuk saleniuk was automatically assigned from wireapp/android

@MohamadJaara MohamadJaara Awaiting requested review from MohamadJaara

@mchenani mchenani Awaiting requested review from mchenani

@Garzas Garzas Awaiting requested review from Garzas

Assignees

@ohassine ohassine

Labels
echoes: throughput/ci-maintenance Changes we need to do to keep CI healthy and fast size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ohassine @AndroidBob @vitorhugods @yamilmedina