Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: errors in fdroid build script causeing it to build DevDebug instead of FdroidRelease #3060

Merged
merged 3 commits into from
Jun 3, 2024

Conversation

MohamadJaara
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

  1. add the correct env variable to the build script.
  2. the script was runnign detekt twice.
  3. unit test run is also dublicated and have and error

Solutions

  1. remove not needed gradle commands
  2. fix the script

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link

sonarcloud bot commented Jun 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@@ -27,6 +27,7 @@ buildscript {
classpath(libs.hilt.gradlePlugin)
val fdroidBuild = (System.getenv("flavor")
?: System.getenv("FLAVOR")
?: System.getenv("CUSTOM_FLAVOR")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should really document these in a BUILDING.md file or similar.

So we could summarise all of the process not only for newcomers but for us. There might be room to simplify stuff but I can say from my side that it's a bit hard to wrap my head around all the env variables needed to make releases.

Copy link
Contributor

github-actions bot commented Jun 3, 2024

Test Results

928 tests   928 ✅  11m 16s ⏱️
123 suites    0 💤
123 files      0 ❌

Results for commit 8bfd24d.

Copy link
Contributor

github-actions bot commented Jun 3, 2024

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 5108 succeeded.

The build produced the following APK's:

@vitorhugods vitorhugods merged commit 00f3521 into release/candidate Jun 3, 2024
15 checks passed
@vitorhugods vitorhugods deleted the chore/fdroid-build-changes branch June 3, 2024 08:53
github-actions bot pushed a commit that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants