Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: s3 path for artifacts adjustment (WPB-8730) #3131

Merged
merged 5 commits into from
Jun 27, 2024

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Jun 26, 2024

TaskWPB-8730 [Android] Upload builds to AWS S3


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Some of the destinations paths when we build the apps, needs to be adjusted so QA can find it easily for their automation scripts. Specially the ones for branches (non PR) also needs to maintain the name.

Solutions

Use a different destination for the apk when uploading to s3

  • For Branches, stays under buildFlavor/buildType
  • For PRs, they are added to a specific folder PR-{{NUMBER}}

In this way we keep retrocompatibility with what we had before in Jenkins.

How to Test

Look for the paths under this PR.
#3131 (comment)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina changed the title chore: s3 path for artifacts adjustment chore: s3 path for artifacts adjustment (WPB-8730) Jun 26, 2024
Copy link

sonarcloud bot commented Jun 27, 2024

Copy link
Contributor

Built wire-android-staging-release-pr-3131.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3131.apk is available for download

@yamilmedina yamilmedina marked this pull request as ready for review June 27, 2024 08:43
@yamilmedina yamilmedina requested review from borichellow, vitorhugods, ohassine, saleniuk, a team and typfel and removed request for a team June 27, 2024 08:51
@yamilmedina yamilmedina changed the title chore: s3 path for artifacts adjustment (WPB-8730) ci: s3 path for artifacts adjustment (WPB-8730) Jun 27, 2024
@yamilmedina yamilmedina requested a review from Garzas June 27, 2024 09:12
@yamilmedina yamilmedina added this pull request to the merge queue Jun 27, 2024
Merged via the queue into develop with commit 1ab655a Jun 27, 2024
14 checks passed
@yamilmedina yamilmedina deleted the chore/s3path-for-artifacts branch June 27, 2024 10:42
@echoes-hq echoes-hq bot added the echoes: throughput/ci-maintenance Changes we need to do to keep CI healthy and fast label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: throughput/ci-maintenance Changes we need to do to keep CI healthy and fast size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants