chore: externalize all wire links to support custom builds (WPB-9811) 🍒 🍒 #3165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.github.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
cherry-pick
Ups 🫰🟨This PR is too big. Please try to break it up into smaller PRs. |
|
yamilmedina
requested review from
yamilmedina,
a team,
typfel,
borichellow,
vitorhugods and
Garzas
and removed request for
a team
yamilmedina
approved these changes
Jul 8, 2024
alexandreferris
approved these changes
Jul 8, 2024
vitorhugods
reviewed
Jul 8, 2024
vitorhugods
approved these changes
Jul 8, 2024
|
Built wire-android-staging-compat-pr-3165.apk is available for download |
|
Built wire-android-dev-debug-pr-3165.apk is available for download |
yamilmedina
deleted the
chore/links-for-custombuilds-cherry-pick-cherry-pick
branch
echoes-hq
bot
added
the
echoes: bugs
b1pb1p
added
echoes: throughput
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically cherry-picked based on the following PR:
Original PR description:
This PR was automatically cherry-picked based on the following PR:
Original PR description:
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
For custom builds, we need to support external URLs not necessary into the wire website.
Causes (Optional)
Not supported / Out of initial scope
Solutions
urls.xmlfile, so external builds can have their own if necessary.Note
Most of the changes are removing entries from strings resources, this can be ignored to have a better review.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.