fix: Better error messages on github action or smoke run failures (WPB-9676) #3169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mythsunwind
changed the title
|
Built wire-android-staging-compat-pr-3169.apk is available for download |
|
Built wire-android-dev-debug-pr-3169.apk is available for download |
yamilmedina
approved these changes
Jul 8, 2024
|
|
Built wire-android-staging-compat-pr-3169.apk is available for download |
|
Built wire-android-dev-debug-pr-3169.apk is available for download |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
The smoke test trigger script threw confusing error messages when a github action was aborted or failed (in case of unit test failures or similar).
Solutions
The change returns a better error message if a github action failed or was aborted. Additionally it adds the URL of the smoke test job to the chat message in case of smoke failures.