Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: asset restriction [WPB-9947] (#2831) (#2856) (#2862) (#3157) #3170

Merged
merged 5 commits into from
Jul 9, 2024

Conversation

MohamadJaara
Copy link
Member

@MohamadJaara MohamadJaara commented Jul 8, 2024

TaskWPB-9947 [Android] Implement asset sending restriction


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

asset restriction when sending, was not implemented

Solutions

show a snack bar error messag when sending a restricted file

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Jul 8, 2024

Built wire-android-staging-compat-pr-3170.apk is available for download

Copy link
Contributor

github-actions bot commented Jul 8, 2024

Built wire-android-dev-debug-pr-3170.apk is available for download

Copy link

sonarcloud bot commented Jul 8, 2024

Copy link
Contributor

github-actions bot commented Jul 8, 2024

Built wire-android-staging-compat-pr-3170.apk is available for download

Copy link
Contributor

github-actions bot commented Jul 8, 2024

Built wire-android-dev-debug-pr-3170.apk is available for download

@MohamadJaara MohamadJaara added this pull request to the merge queue Jul 9, 2024
Merged via the queue into develop with commit bce97f8 Jul 9, 2024
11 of 12 checks passed
@MohamadJaara MohamadJaara deleted the fix/asset-restriction-dev branch July 9, 2024 09:25
@echoes-hq echoes-hq bot added the echoes: features End-user visible changes intended to create customer value label Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: features End-user visible changes intended to create customer value size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants