Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Do not send data to Analytics on custom backend (WPB-10020) #3294

Conversation

alexandreferris
Copy link
Contributor

@alexandreferris alexandreferris commented Aug 7, 2024

TaskWPB-10020 [Android] Do not send data to Countly from custom backends


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

We were sending analytics to custom backends (and not only prod)

Causes (Optional)

No verification was implemented

Solutions

Add verification of current API URL and verify agains PROD API URL so ignoring any other custom backend (staging included).

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

-- Test 1

  • Having analytics enabled
  • Login to prod and check that data is sent to analytics

-- Test 2

  • Having analytics enabled
  • Login to a custom backend and check that data is not sent to analytics

Signed-off-by: alexandreferris <ferris.alexandre@gmail.com>
Signed-off-by: alexandreferris <ferris.alexandre@gmail.com>
Signed-off-by: alexandreferris <ferris.alexandre@gmail.com>
Signed-off-by: alexandreferris <ferris.alexandre@gmail.com>
…n_custom_backend' into chore/do_not_send_countly_data_on_custom_backend
Copy link

sonarcloud bot commented Aug 7, 2024

@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 44.44%. Comparing base (2a084d0) to head (5b5aa4d).

Files Patch % Lines
...rc/main/kotlin/com/wire/android/WireApplication.kt 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           release/candidate    #3294   +/-   ##
==================================================
  Coverage              44.43%   44.44%           
==================================================
  Files                    453      453           
  Lines                  15298    15302    +4     
  Branches                2552     2554    +2     
==================================================
+ Hits                    6798     6801    +3     
- Misses                  7784     7785    +1     
  Partials                 716      716           
Files Coverage Δ
...analytics/ObserveCurrentSessionAnalyticsUseCase.kt 82.35% <100.00%> (+1.70%) ⬆️
...rc/main/kotlin/com/wire/android/WireApplication.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a084d0...5b5aa4d. Read the comment docs.

Copy link
Contributor

github-actions bot commented Aug 7, 2024

Built wire-android-staging-compat-pr-3294.apk is available for download

Copy link
Contributor

github-actions bot commented Aug 7, 2024

Built wire-android-internal-compat-pr-3294.apk is available for download

@alexandreferris alexandreferris requested review from a team, yamilmedina, borichellow, MohamadJaara, vitorhugods and Garzas and removed request for a team August 7, 2024 09:35
Copy link
Contributor

@yamilmedina yamilmedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexandreferris alexandreferris added this pull request to the merge queue Aug 7, 2024
Merged via the queue into release/candidate with commit 9704c19 Aug 7, 2024
12 checks passed
@alexandreferris alexandreferris deleted the chore/do_not_send_countly_data_on_custom_backend branch August 7, 2024 11:50
github-actions bot pushed a commit that referenced this pull request Aug 7, 2024
…3294)

Signed-off-by: alexandreferris <ferris.alexandre@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants