Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typos in compatrelease artifacts (WPB-8645) #3303

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Aug 8, 2024

EpicWPB-8645 [Android] Infrastructure code and developer experience


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Artifacts are not found while trying to upload to the store.

Causes (Optional)

prodCompatRelease <> prodCompatrelease

Solutions

Fix typos for the buildtypes.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina self-assigned this Aug 8, 2024
@echoes-hq echoes-hq bot added the echoes: throughput/ci-maintenance Changes we need to do to keep CI healthy and fast label Aug 8, 2024
@yamilmedina yamilmedina requested review from MohamadJaara, alexandreferris, a team, borichellow, mchenani and ohassine and removed request for a team August 8, 2024 21:00
Copy link

sonarcloud bot commented Aug 8, 2024

Copy link
Contributor

github-actions bot commented Aug 8, 2024

Built wire-android-staging-compat-pr-3303.apk is available for download

Copy link
Contributor

github-actions bot commented Aug 8, 2024

Built wire-android-internal-compat-pr-3303.apk is available for download

@yamilmedina yamilmedina added this pull request to the merge queue Aug 9, 2024
Merged via the queue into release/candidate with commit 87be8a4 Aug 9, 2024
13 checks passed
@yamilmedina yamilmedina deleted the ci/fix-typos-compatrelease branch August 9, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: throughput/ci-maintenance Changes we need to do to keep CI healthy and fast size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants