fix: add new analytics dialog copy and remove redundant (link) (WPB-10803) #3404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he text Signed-off-by: alexandreferris <ferris.alexandre@gmail.com>
alexandreferris
requested review from
a team,
yamilmedina,
MohamadJaara,
mchenani,
Garzas and
ohassine
and removed request for
a team
|
Built wire-android-staging-compat-pr-3404.apk is available for download |
echoes-hq
bot
added
the
echoes/initiative: product-metrics-in-countly
…dialog_copy_for_privacy_link
|
yamilmedina
approved these changes
Aug 29, 2024
|
Built wire-android-staging-compat-pr-3404.apk is available for download |
ohassine
approved these changes
Aug 29, 2024
alexandreferris
deleted the
fix/remove_redundant_analytics_dialog_copy_for_privacy_link
branch
github-actions bot
pushed a commit
that referenced
this pull request
Aug 29, 2024
…0803) (#3404) Signed-off-by: alexandreferris <ferris.alexandre@gmail.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
Wrong dialog copy and redundant (link) text for Privacy Policy
Causes (Optional)
A new dialog copy was in place and we had a redundant (link) text regarding Privacy Policy, but as we already have a button for Privacy Policy, it could be removed.
Solutions
Testing
How to Test
Attachments (Optional)