fix: crash on removing images on preview screen [WPB-11147]

[saleniuk]

WPB-11147 [Android] Crash on removing images on preview page

---

PR Submission Checklist for internal contributors

• The PR Title

  • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
  • contains a reference JIRA issue number like SQPIT-764
  • answers the question: If merged, this PR will: ... ³

• The PR Description

  • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

---

What's new in this PR?

Issues

The app crashes when user tries to remove not currently selected image on preview screen.

Causes (Optional)

HorizontalPager uses SubcomposeLayout, so after changing the state and removing some items, it still uses old state containing removed element when running the subcomposition to compose pages.

Solutions

Provide a key which uniquely identifies each page, so if you add/remove items before the current visible item the item with the given key will be kept as the first visible one.

Testing

How to Test

STR:
-open conversation
-tap on attachments > gallery
-select 3 images
-on preview screen, tap on the second image (to see it in full view)
-delete the first image
-app should not crash and the image should be removed

---

PR Post Submission Checklist for internal contributors (Optional)

• Wire's Github Workflow has automatically linked the PR to a JIRA issue

---

PR Post Merge Checklist for internal contributors

• If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

---

References

1. https://sparkbox.com/foundry/semantic_commit_messages
2. https://github.com/wireapp/.github#usage
3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[github-actions]

Built wire-android-staging-compat-pr-3457.apk is available for download