Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong service opens when clicking on search result [WPB-11330] #3476

Merged

Conversation

saleniuk
Copy link
Contributor

@saleniuk saleniuk commented Sep 30, 2024

BugWPB-11330 [Android] When searching for a service and clicking on search result, wrong service opens


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

When searching for a service and clicking on search result, wrong service opens.

Causes (Optional)

Items are not identified by any key, only by index and clickable is remembered without any key, so items can be reused with clickable remembered for other service.

Solutions

Use folderWithElements which is our common way of showing lists and it already enforces associating key to each item. Use remembered with a key for clickable.

Testing

How to Test

STR:
-have multiple services in your team available (Wire prod has them)
-open any group where you are admin
-tap on “add participants” tab
-tap on “services”
-search for a service (e.g. “Echo”)
-tap on the found service

Expected: I should see the service I searched for

Attachments (Optional)

Before After
service_click_before.mp4
service_click_after.mp4

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@saleniuk saleniuk requested review from a team, typfel, alexandreferris, mchenani, Garzas and mathias-niboulies and removed request for a team September 30, 2024 12:13
Copy link

sonarcloud bot commented Sep 30, 2024

Copy link
Contributor

Built wire-android-staging-compat-pr-3476.apk is available for download

@saleniuk saleniuk added this pull request to the merge queue Sep 30, 2024
Merged via the queue into release/candidate with commit 8f3242f Sep 30, 2024
14 checks passed
@saleniuk saleniuk deleted the fix/clicking-on-service-when-adding-to-group branch September 30, 2024 14:16
@echoes-hq echoes-hq bot added the echoes: bugs Technical or functional defects in the product label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: bugs Technical or functional defects in the product size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants