Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 2020/12/21 #400

Merged
merged 6 commits into from
Dec 22, 2020
Merged

Release 2020/12/21 #400

merged 6 commits into from
Dec 22, 2020

Conversation

fisx
Copy link
Contributor

@fisx fisx commented Dec 21, 2020

@fisx fisx requested a review from arianvp December 22, 2020 09:21
arianvp
arianvp suggested changes Dec 22, 2020
View reviewed changes
Copy link
Contributor

@arianvp arianvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please actually make this a release PR. wrong base-branch

@fisx fisx changed the base branch from develop to master December 22, 2020 10:21
@fisx fisx requested a review from arianvp December 22, 2020 10:21
arianvp
arianvp approved these changes Dec 22, 2020
View reviewed changes
Copy link
Contributor

@arianvp arianvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚋

Remember to wait for the docker images to be pushed before merging this.

@fisx fisx merged commit 61c8bd5 into master Dec 22, 2020
@fisx fisx deleted the release/2020-12-21 branch December 22, 2020 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arianvp arianvp arianvp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fisx @arianvp @smatting @lucendio