-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FS-1334] Reset a Remote Subconversation #2964
Conversation
Closing this in favor of #2956 |
Err nevermind |
- These tests are parameterised by whether the user is a member of the subconversation
983a88a
to
2a4e43c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. However, the test coverage is a bit strange. If I'm not mistaken, we're testing the failure case of a non-member attempting to reset only in the remote case.
Another question: is a client that is not part of a subconversation allowed to reset it?
A fair point. I just added a test for the local case.
My understanding is that a client is allowed to reset a subconversation so long as they're a member of the parent conversation. They don't necessarily have to be in the subconversation. |
As part of https://wearezeta.atlassian.net/browse/FS-1334, this PR adds support for resetting a remote subconversation. The local case was done in PR #2956.
Checklist
changelog.d