Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add conversation.protocol-update event #3277

Merged
merged 1 commit into from
May 9, 2023
Merged

Add conversation.protocol-update event #3277

merged 1 commit into from
May 9, 2023

Conversation

smatting
Copy link
Contributor

@smatting smatting commented May 9, 2023

This PR adds sending a conversation.update-protocol event to all conversation participants when the protocol is switched.

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label May 9, 2023
battermann
battermann approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@battermann battermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smatting
Copy link
Contributor Author

smatting commented May 9, 2023

Integration tests passed

@smatting smatting merged commit b5aa081 into mls May 9, 2023
@smatting smatting deleted the FS-1574-events branch May 9, 2023 11:16
smatting added a commit that referenced this pull request May 9, 2023
@smatting
Add conversation.protocol-update event (#3277)
33e5487
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@battermann battermann battermann approved these changes

Assignees
No one assigned
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smatting @battermann @zebot