Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WPB-4984] Queue remote MLS messages #3635

Merged
merged 7 commits into from
Oct 10, 2023
Merged

[WPB-4984] Queue remote MLS messages #3635

merged 7 commits into from
Oct 10, 2023

Conversation

pcapriotti
Copy link
Contributor

@pcapriotti pcapriotti commented Oct 9, 2023 •
edited by mdimjasevic
Loading

Queue remote MLS messages.

Tracked by https://wearezeta.atlassian.net/browse/WPB-4984.

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@pcapriotti pcapriotti changed the base branch from develop to mls October 9, 2023 12:30
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Oct 9, 2023
@mdimjasevic mdimjasevic self-requested a review October 9, 2023 13:06
@mdimjasevic mdimjasevic changed the title Queue remote MLS messages [WPB-4984] Queue remote MLS messages Oct 9, 2023
@mdimjasevic mdimjasevic marked this pull request as ready for review October 9, 2023 13:45
pcapriotti and others added 6 commits October 10, 2023 09:56
@pcapriotti
Enqueue remote MLS messages
3ce872f
@pcapriotti
Integration test fixes
abe7b40 
Some tests now have to wait for MLS messages to go through to the other
side before continuing. Since message sending is asynchronous, this
means waiting for a notification on a web socket.
@pcapriotti
Remove failed_to_send assertion
4d9882d
@pcapriotti
Add happy path test of MLS messages
89be3e0 
Also remove unnecessary mock tests from galley integration
@pcapriotti
Linter
205c885
@mdimjasevic @pcapriotti
Add a changelog
315032f
@mdimjasevic
Copy link
Contributor

This didn't automatically switch to develop as the target. @pcapriotti , I guess you haven't deleted the mls branch automatically when merging the branch.

@pcapriotti pcapriotti changed the base branch from mls to develop October 10, 2023 13:20
@pcapriotti
Copy link
Contributor Author

This didn't automatically switch to develop as the target. @pcapriotti , I guess you haven't deleted the mls branch automatically when merging the branch.

I guess because mls was a protected branch.

@pcapriotti pcapriotti merged commit 226a4ef into develop Oct 10, 2023
9 checks passed
@pcapriotti pcapriotti deleted the pcapriotti/mls-message-queue branch October 10, 2023 13:21
This was referenced Oct 19, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdimjasevic mdimjasevic mdimjasevic approved these changes

Assignees
No one assigned
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pcapriotti @mdimjasevic @zebot