Recover "WPB-5204 Remove unused APNS_VOIP code (#3695)" #3967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
stefanwire
approved these changes
Mar 20, 2024
akshaymankar
added a commit
that referenced
this pull request
May 7, 2024
This reverts commit 232a882.
elland
added a commit
that referenced
this pull request
May 8, 2024
* Revert "Recover "WPB-5204 Remove unused APNS_VOIP code (#3695)" (#3967)" This reverts commit 232a882. * integration: Refactor push token generation for tests This will allow writing tests which want more control over the push tokens * integration: WIP: register push token tests * WIP: migrating test to /integration * integration: finished gundeck token test and delete old test * [gundeck] Refactored addToken to use ExceptT * [gundeck] Returns an error when trying to register VOIP tokens. * format * changelog * wire-api/test/unit: Slightly better error message * Remove ApsPreference --------- Co-authored-by: Igor Ranieri <igor@elland.me>
echoes-hq
bot
added
the
echoes: technical-debt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-6583
This reverts commit 133a740 and fixes 66b8c98.
Checklist
changelog.d